Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Updated Types to match JavaScript implementation #12407

Merged
merged 2 commits into from
Jun 26, 2020

Conversation

Keimeno
Copy link
Member

@Keimeno Keimeno commented Jun 22, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Telling the ModelAttributeColumnOptions interface property references to accept strings as well.
This feature is actually implemented into sequelize, as can be seen in the documentation you need to search for attributes.column.references.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #12407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12407   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          95       95           
  Lines        9114     9114           
=======================================
  Hits         8790     8790           
  Misses        324      324           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663261b...59a34e9. Read the comment docs.

@Keimeno Keimeno changed the title Updated Types to match JavaScript implementation feat(types): Updated Types to match JavaScript implementation Jun 22, 2020
@Keimeno Keimeno changed the title feat(types): Updated Types to match JavaScript implementation fix(types): Updated Types to match JavaScript implementation Jun 24, 2020
@sushantdhiman sushantdhiman merged commit 962ed3c into sequelize:master Jun 26, 2020
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Keimeno Keimeno deleted the feature/fix-model-types branch August 15, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants