Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): insert and upsert operations do not return all fields #12433

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

ShaharHD
Copy link
Contributor

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes Insert and Upsert operations on MSSQL do not return all fields  #12432 ) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

When using the MSSQL dialect, running Insert or Upsert operations, the mssql dialect is ignoring the values returned by OUTPUT INSERTED.* which can also include defaults values populated by the database or fields being updated by various triggers.

When using the MSSQL dialect, running Insert or Upsert operations, the mssql dialect is ignoring the values returned by OUTPUT INSERTED.* which can also include defaults values populated by the database or fields being updated by various triggers.

See sequelize#12432 for additional details
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert and Upsert operations on MSSQL do not return all fields
2 participants