Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark database drivers as optional peer dependencies #12494

Merged
merged 1 commit into from
Jul 11, 2020
Merged

fix: mark database drivers as optional peer dependencies #12494

merged 1 commit into from
Jul 11, 2020

Conversation

DRoet
Copy link
Contributor

@DRoet DRoet commented Jul 11, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

same as #12484 but for the master branch

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #12494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12494   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files          95       95           
  Lines        9257     9257           
  Branches       61       61           
=======================================
  Hits         8922     8922           
  Misses        322      322           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d0cdb...5dd3f95. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 161d445 into sequelize:master Jul 11, 2020
@DRoet DRoet deleted the fix/yarn-pnp-master branch July 11, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants