Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixing typo dialect for mssql connection #12759

Closed
wants to merge 1 commit into from

Conversation

ilhamarrouf
Copy link

@ilhamarrouf ilhamarrouf commented Oct 15, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #12759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12759   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          95       95           
  Lines        9261     9261           
  Branches       90       90           
=======================================
  Hits         8921     8921           
  Misses        323      323           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febc083...77e91ae. Read the comment docs.

@papb
Copy link
Member

papb commented Oct 15, 2020

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

Nice catch!

Please switch the target branch of your merge from master to v6, currently any docs update must go there instead of master; and GitHub does not let me do it, it has to be the PR author. There should be a button somewhere for you to switch the target branch. Thanks!

@djake djake added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Jan 12, 2021
@sdepold
Copy link
Member

sdepold commented Oct 24, 2021

Hey there :)

First of all: Thanks a bunch for your contribution to Sequelize! Much appreciated!
Second: Unfortunately we haven't had the chance to look into this ever since you created it. Sorry for that!

A couple of months ago, we have switched from master to main branch as our primary development branch and hence this PR is now outdated :(

If you still think this change is making sense, please consider recreating the PR against main. Thanks in advance and sorry for the additional work.

✌️

@github-actions github-actions bot added the stale label Nov 1, 2021
@github-actions github-actions bot closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants