Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved the typescript issue with the Op.match (https://github.com/sequelize/sequelize/pull/12955) #13481

Merged
merged 9 commits into from
Nov 15, 2021

Conversation

vikasg603
Copy link
Contributor

resolved the typescript issue for Op.match (#12955)

vikas gupta and others added 3 commits September 7, 2021 00:13
@Keimeno
Copy link
Member

Keimeno commented Oct 10, 2021

Hi @vikasg603, thanks for your PR.

Can you please add the Operator to the WhereOperators interface in the model.d.ts file as well, and also typing tests to ensure, that Op.match works as expected?

You can look at the following PR as reference: https://github.com/sequelize/sequelize/pull/13499/files

@Keimeno Keimeno added type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action labels Oct 10, 2021
@github-actions github-actions bot removed the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Oct 10, 2021
@sdepold sdepold merged commit 0ecb0e1 into sequelize:main Nov 15, 2021
@Keimeno Keimeno mentioned this pull request Nov 15, 2021
6 tasks
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
…quelize#13481)

* Update operators.d.ts

resolved the typescript issue for Op.match (sequelize#12955)

* Update operators.d.ts

Co-authored-by: Constantin Metz <58604248+Keimeno@users.noreply.github.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants