-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(operators): convert operators to typescript #13731
Conversation
To avoid name clashes with your global symbol keys and other (library code) global symbols, it might be a good idea to prefix your symbols
Since papb no longer active maintaining directly in the repository, so I assign @sdepold to review this. |
Could you maybe migrate this file to TypeScript as well? Otherwise we will have to change this file twice in a short time |
Okay, will work on it, drafted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeScript changes look okay, but I'll leave it open for people with more experience. I do have some remarks about the other changes you made
I added some last bits to the PR |
🎉 This PR is included in version 6.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* refactor(operators): symbol keys prefix To avoid name clashes with your global symbol keys and other (library code) global symbols, it might be a good idea to prefix your symbols * feat: add operators.ts * feat: add operators.ts * Not an object * Change to string * refactor(operators): convert to typescript * fix(operators): revert values back to original values Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com> Co-authored-by: Sascha Depold <sascha@depold.com>
Pull Request Checklist
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description Of Change
To avoid name clashes with your global symbol keys and other (library code) global symbols, it might be a good idea to prefix your symbols
Todos