Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: allow db2 tests to fail #13936

Merged
merged 3 commits into from
Jan 12, 2022
Merged

build: allow db2 tests to fail #13936

merged 3 commits into from
Jan 12, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Jan 10, 2022

I noticed that DB2 tests were failing but CI still let them pass, this should solve that

ephys
ephys approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. Is there a reason why db2 was allowed to fail?

@sdepold
Copy link
Member

sdepold commented Jan 11, 2022

I guess we did that because it was considered experimental. It seems semi stable however?

@WikiRik
Copy link
Member Author

WikiRik commented Jan 11, 2022

I guess we did that because it was considered experimental. It seems semi stable however?

They are two flaky tests for DB2 (especially for Node 12) but in general it seems to be running fine. At least we can see that some tests have failed. Maintainers can still merge even if DB2 tests fail because they are not required so there is no big harm in this change. But I'll leave it up to you @sdepold to merge

@sdepold
Copy link
Member

sdepold commented Jan 12, 2022

Aaaand it is optional for the release step right?

fzn0x
fzn0x approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@fzn0x fzn0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it's just worked like p-retry when we scrape something and got cloudflare in front of us but it turns out it's not.

LGTM.

@sdepold sdepold merged commit bfb54d4 into main Jan 12, 2022
@sdepold sdepold deleted the fix-db2-tests branch January 12, 2022 06:50
@ephys
Copy link
Member

ephys commented Jan 12, 2022

I think I get why the tests were allowed to fail now 😅

heroic pushed a commit to galaxycard/sequelize that referenced this pull request Jan 12, 2022
@WikiRik
build: allow db2 tests to fail (sequelize#13936)
2b2af60
@sdepold
Copy link
Member

sdepold commented Jan 12, 2022

I think I get why the tests were allowed to fail now 😅

😅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

🎉 This PR is included in version 7.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@fzn0x fzn0x fzn0x approved these changes

@sdepold sdepold Awaiting requested review from sdepold

Assignees
No one assigned
Labels
released on @v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WikiRik @sdepold @ephys @fzn0x