refactor(data-types): convert mysql data-types to TS #13981
Conversation
wbourne0
added
type: refactor
|
The lodash types are added in #13782 which I think we'll merge first and then you can merge/rebase main in the various branches |
There was a problem hiding this comment.
Two remarks on the package.json. Also would like to point out that we check for expiring TODOs (as a linter warning); https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/expiring-todo-comments.md
Not sure if they really fit in this PR but just so you know about them
package.json
Outdated
| "@types/chai": "4.3.0", | ||
| "@types/mocha": "9.0.0", | ||
| "@types/mysql": "^2.15.20", |
There was a problem hiding this comment.
This one needs to be pinned, otherwise renovate will do that
package.json
Outdated
| @@ -58,14 +58,15 @@ | |||
| "wkx": "^0.5.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@rushstack/eslint-patch": "1.1.0", | |||
There was a problem hiding this comment.
I can remember other PRs that also change this and ibm_db so we don't have to do this here. I'll check which one and if that one is not looking like it will be merged soon I will make a separate PR
wbourne0
force-pushed
the
typeify-mysql-data-types
branch
from
3bf9417
to
361ae11
Compare
wbourne0
force-pushed
the
typeify-mysql-data-types
branch
from
361ae11
to
9460468
Compare
wbourne0
force-pushed
the
typeify-data-types
branch
from
6de690b
to
210279c
Compare
Refactors mysql-specific dialect types to be TS and to work with the new DataTypes format.
wbourne0
force-pushed
the
typeify-mysql-data-types
branch
from
9460468
to
8fe1660
Compare
|
Closing in favor of #14505. |
Note: This is a child PR of #13799 - it should only be merged into that branch when both this pr and that pr have been approved.
(note: omitted the PR checklist as it isn't really relevant here)
Description Of Change
converts mysql-specific data-types to TS.
Also refactors the data-types to work with the (proposed) format from the master pr, #13799.