Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): deduplicate error typings #14002

Merged
merged 2 commits into from Jan 25, 2022
Merged

fix(types): deduplicate error typings #14002

merged 2 commits into from Jan 25, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Jan 24, 2022

Pull Request Checklist

  • [n/a] Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • [n/a] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Closes #14000, I hope

This PR deduplicates the typing definitions for Error classes, as types/lib/errors.d.ts wasn't removed and was shadowing lib/errors.
I also fixed issues detected in lib/errors once it wasn't shadowed anymore

@ephys ephys added type: bug type: typescript labels Jan 24, 2022
@WikiRik
Copy link
Member

@WikiRik WikiRik commented Jan 24, 2022

Just to check, this is compatible with the v6 branch right?

@ephys
Copy link
Member Author

@ephys ephys commented Jan 24, 2022

It should be. I've aligned the new files with the old typing definitions. But I'll double check that everything that was exported, still is

@WikiRik
Copy link
Member

@WikiRik WikiRik commented Jan 24, 2022

I was mostly thinking about files that weren't converted to TS in the v6 branch but I haven't looked at your changes yet.

@ephys
Copy link
Member Author

@ephys ephys commented Jan 24, 2022

These files were converted to TS just before we stopped the migration for v6 :) https://github.com/sequelize/sequelize/tree/v6/lib/errors

@ephys ephys self-assigned this Jan 24, 2022
Copy link
Member

@WikiRik WikiRik left a comment

Looks good!

lib/errors/aggregate-error.ts Show resolved Hide resolved
@ephys ephys merged commit 3f75880 into main Jan 25, 2022
40 of 42 checks passed
@ephys ephys deleted the ephys/14000 branch Jan 25, 2022
@sdepold sdepold added this to To be released in Sequelize v6 release log Jan 29, 2022
@sdepold sdepold moved this from To be released to Releasing in Sequelize v6 release log Jan 29, 2022
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 7, 2022

🎉 This PR is included in version 7.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @v7 type: bug type: typescript
Projects
Development

Successfully merging this pull request may close these issues.

3 participants