Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gen /lib & /types from /src & drop /dist (main) #14068

Merged
merged 11 commits into from Feb 9, 2022
Merged

feat: gen /lib & /types from /src & drop /dist (main) #14068

merged 11 commits into from Feb 9, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Feb 8, 2022

This PR cherry-picks PR #14063 into the main branch

@ephys ephys changed the title feat: bring #14063 into main Bring #14063 into main Feb 8, 2022
@ephys ephys changed the title Bring #14063 into main feat: gen /lib & /types from /src & drop /dist (main) Feb 8, 2022
@ephys
Copy link
Member Author

ephys commented Feb 8, 2022

Given most changes are simple file renames, I'm hoping to see a minimum amount of conflict in existing PRs

WikiRik
WikiRik previously approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the legacy file can be removed without other changes so that might be for a next PR. Can you also make a PR soon for linting the additional folders?

src/query.d.ts Outdated Show resolved Hide resolved
@ephys
Copy link
Member Author

ephys commented Feb 8, 2022

Didn't notice the linter was failing. It's fixed now

@ephys ephys requested a review from a team February 8, 2022 17:59
ephys
ephys commented Feb 8, 2022
View reviewed changes
.eslintrc.js Show resolved Hide resolved
@ephys
Copy link
Member Author

ephys commented Feb 9, 2022

I'll cherry pick #14073 in this PR once it's merged

WikiRik
WikiRik reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, but otherwise we are good

.eslintrc.js Show resolved Hide resolved
WikiRik
WikiRik previously approved these changes Feb 9, 2022
View reviewed changes
@ephys
Copy link
Member Author

ephys commented Feb 9, 2022

@WikiRik Sorry, your review is already stale 😅 I included the changes from #14073

WikiRik
WikiRik previously approved these changes Feb 9, 2022
View reviewed changes
@ephys
Copy link
Member Author

ephys commented Feb 9, 2022

And I'll need to dismiss it again, turns our that Sequelize.version was untested and untyped :o

image

@ephys ephys mentioned this pull request Feb 9, 2022
Closed
6 tasks
@ephys ephys merged commit 491ff15 into main Feb 9, 2022
@ephys ephys deleted the ephys/41038-in-main branch February 9, 2022 09:03
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ephys ephys mentioned this pull request Feb 21, 2022
Closed
vanthome pushed a commit to vanthome/sequelize that referenced this pull request Jun 12, 2022
@ephys @vanthome
feat: gen /lib & /types from /src & drop /dist (main) (sequelize#14068)
17a1d32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
released on @v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ephys @WikiRik