refactor(data-types): convert mariadb data-types to TS #14240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbourne0
added
type: refactor
6 tasks
wbourne0
force-pushed
the
typeify-data-types
branch
from
6de690b
to
210279c
Compare
wbourne0
force-pushed
the
typeify-maraiadb-data-types
branch
from
c0a341a
to
210279c
Compare
Refactors mariadb-specific dialect types to be TS and to work with the new DataTypes format.
WikiRik
approved these changes
Apr 10, 2022
There was a problem hiding this comment.
Looks good. I have one suggestion though.
Also; in the js file we have
BaseTypes.ABSTRACT.prototype.dialectTypes = 'https://mariadb.com/kb/en/library/resultset/#field-types';Is there a reason this is not present anymore in the ts file? Haven't looked at the other PRs though so I might just have missed it
| this.sqlType = this.key; | ||
| } else { | ||
| if (!this.type) { | ||
| throw new Error('Expected GEOMETRY type'); |
There was a problem hiding this comment.
Maybe we can add a nicer error message here?
|
Closing in favor of #14505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a child PR of #13799 - it should only be merged into that branch when both this pr and that pr have been approved.
(note: omitted the PR checklist as it isn't really relevant here)
Description Of Change
converts mariadb-specific data-types to TS.
Also refactors the data-types to work with the (proposed) format from the master pr, #13799.