New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve various db2 issues #14453
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
946687f
to
4c9c546
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I've changed how deleting I've also re-added forced table reorg inside queryInterface, instead of tests (note that before it was in Only finger crossing left to be done |
@ephys can you check out the failed tests? I think they are due to this PR |
Hmm that's annoying.
|
…sequelize into ephys/db2-debug-please-ignore
🎉 This PR is included in version 7.0.0-alpha.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR (hopefully) fixes the underlying issue that caused DB2 tests to be flaky:
Db2Query
was silencing errors emitted by DB2 in an attempt to fix them automatically.This PR removes that. It appears the flakiness is gone, and this PR fixes the issues that were hidden by that behavior.
List of fixed issues:
Db2Query
muted errors. This has been removed.createTable
usedCREATE TABLE
instead ofCREATE TABLE IF NOT EXISTS
(like the other dialects did)dropTable
usedDROP TABLE
instead ofDROP TABLE IF EXISTS
(like the other dialects did)The rest of the changes are adapting the tests to make them work properly with db2.
There is one change we may want to preserve:
This
REORG TABLE
operation was done inDb2Query
. Do we want to preserve it?REORG TABLE
ERRORSCHEMA.ERRORTABLE
CREATE TABLESPACE SYSTOOLSPACE
if the tablespace does not exist