New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(postgres): add custom order direction to subQuery ordering with minified alias #15046
Conversation
Could you add the unit test that was in the original comment as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was just confused. This integration test indeed covers this just fine
Sweet, once the checks pass I'll merge and notify Ashby on the issue thread. |
a2bb0d6
to
ebd0334
Compare
@WikiRik can you please re-approve? Rebased on top of main so I can merge if (fingers crossed when) the checks pass. |
For next time; you can just merge Also; can you backport this to v6 as well? |
OK if I trigger a v7 release that includes this change? |
Go ahead! Could be the final pre-DataTypes release |
🎉 This PR is included in version 7.0.0-alpha.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Checklist
Description Of Change
Fix for new issue raised at #14723.
Essentially, we weren't pushing the order direction when pushing the alias for the sub-query field. This PR adds logic to do so, as well as tests for ascending/descending subquery ordering with aliases.