Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: make Utils.now() and Utils.toDefaultValue() accept a dialect #15072

Merged
merged 1 commit into from Oct 1, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Sep 30, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Part of the PRs split from #14505
I couldn't really find why snowflake doesn't support milliseconds or that it was just an oversight but we can't do integration tests so I'm not risking it.

@WikiRik WikiRik requested a review from ephys September 30, 2022 22:51
@WikiRik WikiRik merged commit 0f4914f into main Oct 1, 2022
@WikiRik WikiRik deleted the WikiRik/dialect-supports-milliseconds branch October 1, 2022 07:28
@ephys ephys mentioned this pull request Oct 1, 2022
42 tasks
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants