feat(postgres): support for `ADD COLUMN IF NOT EXISTS` and `DROP COLUMN IF EXISTS` #15119

frostzt · 2022-10-12T14:54:33Z

Pull Request Checklist

Have you added new tests to prevent regressions?
If a documentation update is necessary, have you opened a PR to the documentation repository?
Did you update the typescript typings accordingly (if applicable)?
Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
Does the name of your PR follow our conventions?

Description Of Change

Its a feature request opened by #14928
Postgres supports IF NOT EXISTS clause on adding columns. Adds support for Postgres dialect!

Todos

Add tests for IF NOT EXISTS both Unit and Integration
Add dialect support check for all the other dialects

frostzt · 2022-10-12T14:56:24Z

@ephys I have few questions on this as you mentioned that dialects that don't support this should throw, I do think there are some workarounds for few of them should I try and implement them if possible. Like for ones that don't support it as you mentioned they can first query it and then try and add it if not exists.

Second question I have is passing that option in the attribute a good idea because I don't think that is what I am supposed to do. Is there a better way to implement it?

Also another question is, as you said should all the dialects that don't support this feature should throw right?

Betree

Nice work @frostzt, it's looking good so far! Thanks for getting the ball rolling on this one.

I'm not the best person to provide a comprehensive review, but I think we should keep #11774 in mind while implementing this.

frostzt · 2022-10-13T07:13:40Z

@ephys I think if the above is correct I can push the changes for #11774 in this PR too?

WikiRik · 2022-10-13T07:24:05Z

I think it would be good to tackle that in this PR as well

fzn0x · 2022-10-13T16:28:19Z

Maybe you can rename this PR to includes DROP COLUMN IF EXIST if you are sure want to tackle it in this PR, it would be great :) @frostzt

ephys

Nice work :)

Yes feel free to add DROP COLUMN it in this PR if you prefer, splitting it is fine too

Could you add a unit test in unit/query-generator/add-column-query.test.ts?

All dialects should be tested, but the ones that don't support the option should throw (like in list-databases-query.test.ts)

I don't think you need an integration test for this option

I do think there are some workarounds for few of them should I try and implement them if possible

I think we can look into that if there is interest but I'd propose to keep it for a follow-up PR

src/dialects/abstract/index.ts

src/dialects/postgres/query-generator.js

fzn0x · 2022-10-13T16:35:36Z

Better PR name :)

ephys · 2022-10-13T16:36:27Z

Gotta be super explicit for the changelog :p

src/dialects/abstract/query-interface.js

src/dialects/postgres/query-generator.js

WikiRik

Few comments about your tests, haven't looked into the rest yet

test/unit/query-generator/add-column-query.test.ts

WikiRik

It seems that this is not a postgres exclusive feature

@ephys I'll let you look at the type definitions for {add,remove}ColumnQuery

test/unit/query-generator/remove-column-query.test.ts

test/unit/query-generator/add-column-query.test.ts

src/dialects/postgres/query-generator.js

src/dialects/postgres/index.js

src/dialects/abstract/query-interface.js

src/dialects/abstract/query-generator.d.ts

src/dialects/mariadb/index.js

src/dialects/mssql/index.js

ephys

This looks good to me. I'm OK with adding support for other dialects in follow-up PRs. :)

WikiRik

Yes, let's add support for additional dialects in future PRs and merge this one now. Would be nice if you could still work on those @frostzt :)

fzn0x · 2022-11-05T19:12:33Z

Happy to see this is landed!

frostzt · 2022-11-06T00:34:35Z

@WikiRik thanks I'll start working on those!

feat: IF NOT EXISTS support for Postgres

4c4cc3a

frostzt marked this pull request as draft October 12, 2022 14:56

Betree reviewed Oct 13, 2022

View reviewed changes

frostzt changed the title ~~feat: IF NOT EXISTS support for Postgres~~ feat(postgres): support for IF NOT EXISTS and DROP IF NOT EXISTS Oct 13, 2022

fzn0x changed the title ~~feat(postgres): support for IF NOT EXISTS and DROP IF NOT EXISTS~~ feat(postgres): support for IF NOT EXISTS and DROP IF EXISTS Oct 13, 2022

ephys requested changes Oct 13, 2022

View reviewed changes

src/dialects/abstract/index.ts Outdated Show resolved Hide resolved

src/dialects/postgres/query-generator.js Outdated Show resolved Hide resolved

ephys changed the title ~~feat(postgres): support for IF NOT EXISTS and DROP IF EXISTS~~ feat(postgres): support for CREATE COLUMN IF NOT EXISTS and DROP COLUMN IF EXISTS Oct 13, 2022

ephys changed the title ~~feat(postgres): support for CREATE COLUMN IF NOT EXISTS and DROP COLUMN IF EXISTS~~ feat(postgres): support for ADD COLUMN IF NOT EXISTS and DROP COLUMN IF EXISTS Oct 13, 2022

frostzt added 3 commits October 15, 2022 16:46

feat: added dialect support check

6e0be2f

feat: added interface definitions

cbdd1a5

feat: added support for query generator and interface

f001f09

frostzt requested a review from ephys October 15, 2022 12:01

ephys reviewed Oct 15, 2022

View reviewed changes

src/dialects/abstract/query-interface.js Outdated Show resolved Hide resolved

ephys reviewed Oct 15, 2022

View reviewed changes

src/dialects/postgres/query-generator.js Outdated Show resolved Hide resolved

ephys reviewed Oct 15, 2022

View reviewed changes

src/dialects/postgres/query-generator.js Outdated Show resolved Hide resolved

fzn0x added the type: feature For issues and PRs. For new features. Never breaking changes. label Oct 16, 2022

feat: removed support for addColumn for MySQL

a93540e

frostzt requested a review from ephys October 16, 2022 12:41

WikiRik reviewed Oct 17, 2022

View reviewed changes

frostzt added 4 commits October 18, 2022 10:49

feat: added options check for all the dialects

f3ad7ab

tests: updated unit tests for query generator

0fced48

fix: pass options as null if query options are not provided

f0048b8

fix: only send options if any of the options are defined

dd5c62f

WikiRik reviewed Oct 18, 2022

View reviewed changes

test/unit/query-generator/add-column-query.test.ts Outdated Show resolved Hide resolved

frostzt added 2 commits October 19, 2022 00:00

fix: pass correct options for column

c134580

feat: implemented 'DROP COLUMN IF EXISTS'

111648b

frostzt requested review from WikiRik and ephys and removed request for ephys and WikiRik October 18, 2022 18:41

frostzt marked this pull request as ready for review October 18, 2022 18:59

WikiRik requested changes Oct 18, 2022

View reviewed changes

frostzt added 3 commits October 19, 2022 10:38

fix: short-circuit options to empty object if null

bd0049c

fix: revert sql check for mysql and mariadb

5e63520

fix: fallback to options on options check

95eeb43

ephys approved these changes Nov 5, 2022

View reviewed changes

WikiRik approved these changes Nov 5, 2022

View reviewed changes

Merge branch 'main' into feat/add-support-for-add-column-if-not-exists

d41a690

WikiRik merged commit 76cc97f into sequelize:main Nov 5, 2022

This was referenced Nov 5, 2022

Support "ADD COLUMN IF NOT EXISTS" #14928

Closed

queryInterface: Support DROP COLUMN IF EXISTS #11774

Closed

theoilie mentioned this pull request Apr 28, 2023

Make storage v2 work without CNs in audius-compose AudiusProject/audius-protocol#5175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(postgres): support for `ADD COLUMN IF NOT EXISTS` and `DROP COLUMN IF EXISTS` #15119

feat(postgres): support for `ADD COLUMN IF NOT EXISTS` and `DROP COLUMN IF EXISTS` #15119

frostzt commented Oct 12, 2022

frostzt commented Oct 12, 2022 •

edited

Betree left a comment

frostzt commented Oct 13, 2022

WikiRik commented Oct 13, 2022

fzn0x commented Oct 13, 2022 •

edited

ephys left a comment

fzn0x commented Oct 13, 2022

ephys commented Oct 13, 2022

WikiRik left a comment

WikiRik left a comment

ephys left a comment

WikiRik left a comment

fzn0x commented Nov 5, 2022

frostzt commented Nov 6, 2022

feat(postgres): support for ADD COLUMN IF NOT EXISTS and DROP COLUMN IF EXISTS #15119

feat(postgres): support for ADD COLUMN IF NOT EXISTS and DROP COLUMN IF EXISTS #15119

Conversation

frostzt commented Oct 12, 2022

Pull Request Checklist

Description Of Change

Todos

frostzt commented Oct 12, 2022 • edited

Betree left a comment

Choose a reason for hiding this comment

frostzt commented Oct 13, 2022

WikiRik commented Oct 13, 2022

fzn0x commented Oct 13, 2022 • edited

ephys left a comment

Choose a reason for hiding this comment

fzn0x commented Oct 13, 2022

ephys commented Oct 13, 2022

WikiRik left a comment

Choose a reason for hiding this comment

WikiRik left a comment

Choose a reason for hiding this comment

ephys left a comment

Choose a reason for hiding this comment

WikiRik left a comment

Choose a reason for hiding this comment

fzn0x commented Nov 5, 2022

frostzt commented Nov 6, 2022

feat(postgres): support for `ADD COLUMN IF NOT EXISTS` and `DROP COLUMN IF EXISTS` #15119

feat(postgres): support for `ADD COLUMN IF NOT EXISTS` and `DROP COLUMN IF EXISTS` #15119

frostzt commented Oct 12, 2022 •

edited

fzn0x commented Oct 13, 2022 •

edited