fix: don't treat \ as escape in standard strings, support E-strings, support vars after ->> operator, treat lowercase e as valid e-string prefix #15139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also support support vars after ->> operator now. Backport of #14700
…ize/sequelize into sdepold/fix-backslash-replacement
WikiRik
reviewed
Oct 18, 2022
…ize/sequelize into sdepold/fix-backslash-replacement
to be completely honest with you, I think we should stop wasting time talking about formatting :D we have the linter in place to prevent syntax problems. it even auto-formats stuff as it see needs. it's all green. so why care about something that is legacy anyway. however, I've reverted the changes to best of my abilities, even preventing the auto-formatting of my editor to turn it all upside down again. |
WikiRik
reviewed
Oct 19, 2022
WikiRik
approved these changes
Oct 19, 2022
ephys
approved these changes
Oct 19, 2022
|
🎉 This PR is included in version 6.25.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14700 and #14733.