Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enables type validation by default #15177

Closed
wants to merge 4 commits into from

Conversation

fzn0x
Copy link
Member

@fzn0x fzn0x commented Oct 24, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Part of the split PRs from #14505

@fzn0x fzn0x requested a review from ephys October 24, 2022 18:07
@fzn0x fzn0x self-assigned this Oct 24, 2022
@fzn0x fzn0x added the type: feature For issues and PRs. For new features. Never breaking changes. label Oct 25, 2022
@WikiRik
Copy link
Member

WikiRik commented Oct 26, 2022

I'd rather not merge this. While I've made some PRs in the past to reduce the size of #14505 I think I've been able to review it enough so additional PRs are not needed anymore.

@fzn0x
Copy link
Member Author

fzn0x commented Oct 26, 2022

Thanks @WikiRik !

@fzn0x fzn0x closed this Oct 26, 2022
@fzn0x fzn0x deleted the feat/enable-type-validation-as-default branch October 26, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature For issues and PRs. For new features. Never breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants