-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add instance.dataValues property to model.d.ts #15208
Conversation
this allows typescript to have a definition for the instance.dataValues property
remove additional space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll take a closer look at this later but you can add this commit to the PR to have this change supported by at least one test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than deleting remove-attribute.test.js, this should be good to go I think
This reverts commit eb39d77.
Just wondering, will this make it to v6? Or do I have to make the PR elsewhere? |
Not directly, but feel free to open a new PR towards v6. Just the change to model.d.ts wil do fine, no need to update the test |
this allows typescript to have a definition for the instance.dataValues property
Pull Request Checklist
Description Of Change
this allows to get typings from
const sampleInstance = SampleModel.findByPk(pk);
sampleInstance.dataValues; //This currently does not exist in typings
Todos