Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: temporal tables #15360

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: temporal tables #15360

wants to merge 5 commits into from

Conversation

lohart13
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR adds temporal table support that can be built on for other dialects.
MSSQL support is add in this PR.

This closes #15359

@ephys ephys self-requested a review November 30, 2022 07:41
@ephys
Copy link
Member

ephys commented Nov 30, 2022

This is a big PR. Thank you for all the work you've been putting in this ORM
I'll need some time to read up & experiment with temporal tables before being able to review this feature properly

@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from 47e10e9 to fb16c4f Compare December 7, 2022 03:16
@lohart13 lohart13 mentioned this pull request Dec 22, 2022
Draft
6 tasks
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from 980b88e to b3eee6e Compare January 20, 2023 08:42
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from c8678fa to 2d5e318 Compare March 20, 2023 04:42
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from 24567de to 00bd421 Compare March 27, 2023 19:39
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 4 times, most recently from c97eaff to dd355c5 Compare April 19, 2023 10:56
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from 4ce4acd to 530c2c7 Compare April 25, 2023 20:43
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from 32804bb to ee302f3 Compare July 19, 2023 09:15
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 4 times, most recently from 9bbe7f9 to 4b55e57 Compare September 12, 2023 01:48
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 3 times, most recently from 51f1607 to 90c2f8c Compare September 19, 2023 01:43
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from cc3a69d to 31ae9d1 Compare December 22, 2023 03:25
@lohart13 lohart13 force-pushed the feat-temporal-tables branch 2 times, most recently from bca9699 to 9398092 Compare January 29, 2024 22:22
@lohart13 lohart13 requested a review from a team as a code owner February 26, 2024 05:54
lohart13
lohart13 commented Feb 26, 2024
View reviewed changes
packages/core/test/integration/model/sync.test.js

const dialect = getTestDialect();

describe(getTestDialectTeaser('Model.sync & Sequelize#sync'), () => {
allowDeprecationsInSuite(['SEQUELIZE0015']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is now required.
The tests would fail otherwise at test updates the deferrable property of a foreign key or should not recreate a foreign key if it already exists when { alter: true } is used with a custom schema

@sequelize-bot sequelize-bot bot added the conflicted This PR has merge conflicts and will not be present in the list of PRs to review label Apr 10, 2024
@sequelize-bot sequelize-bot bot removed the conflicted This PR has merge conflicts and will not be present in the list of PRs to review label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys Awaiting requested review from ephys

@WikiRik WikiRik Awaiting requested review from WikiRik WikiRik is a code owner automatically assigned from sequelize/code-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporal Tables
2 participants
@lohart13 @ephys