feat: Migrate the rest of QI `schema` methods to TS #15498

evanrittenhouse · 2022-12-25T18:15:29Z

Pull Request Checklist

Have you added new tests to prevent regressions?
If a documentation update is necessary, have you opened a PR to the documentation repository?
Did you update the typescript typings accordingly (if applicable)?
Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
Does the name of your PR follow our conventions?

Description Of Change

Migrate the rest of QueryInterface schema methods to TypeScript

WikiRik

One quick comment, I'll let you work on this further yourself. Feel free to let us know if you have any questions

src/dialects/abstract/query-interface.js

evanrittenhouse · 2022-12-26T00:22:49Z

The tests are failing because of Unknown database: sequelize_test on my local branch and when I check out upstream/main (main of the GitHub repo).

What's odd is that on upstream/main, if I stop/restart the container it'll work. Super weird, considering I didn't make any changes to the database methods. Any ideas?

src/dialects/abstract/query-interface-typescript.ts

test/integration/query-interface/schemas.test.ts

WikiRik

I think it's fine that we do not use drop for dialects that do not support schemas. These should not use dropAllSchemas in the first place imo.

test/integration/query-interface/schemas.test.ts

src/dialects/abstract/query-interface.types.ts

src/dialects/abstract/query-interface-typescript.ts

evanrittenhouse · 2023-01-09T02:44:51Z

@WikiRik I'm stumped. Do you why, on MySQL and MariaDB, [MYSQL] Replication connection objects should be able to make a write would fail after dropAllSchemas() runs? I've confirmed that the test database is being recreated

test/integration/query-interface/schemas.test.ts

evanrittenhouse · 2023-01-10T06:21:59Z

Only outstanding question I have is whether we want to deprecate the equivalent methods in sequelize.js. @WikiRik @ephys thoughts?

WikiRik · 2023-01-10T10:57:55Z

Only outstanding question I have is whether we want to deprecate the equivalent methods in sequelize.js. @WikiRik @ephys thoughts?

Probably in the future, but for now I don't think that is necessary. But I'm fine either way

WikiRik

Few comments, but I think we're getting close

src/dialects/abstract/query-interface.types.ts

src/dialects/abstract/query-interface-typescript.ts

test/integration/query-interface/schemas.test.ts

WikiRik

Few additional comments

test/integration/query-interface/schemas.test.ts

src/dialects/abstract/query-interface-typescript.ts

src/dialects/abstract/query-generator.types.ts

src/dialects/abstract/query-interface-typescript.ts

test/integration/query-interface/schemas.test.ts

WikiRik

Two suggestions regarding the types, after those the typing tests should work I think

packages/core/src/dialects/abstract/query-generator.types.ts

packages/core/test/integration/query-interface/schemas.test.ts

evanrittenhouse · 2023-02-01T17:33:19Z

I'm going to move dropAllSchemas() to a different PR as it's preventing the release of the rest of the methods. I haven't been able to sort out the cause of the flaky integration tests.

packages/core/test/integration/query-interface.test.js

WikiRik

Two small comments. If you commit the type back we should be good to go

packages/core/src/dialects/abstract/query-interface.d.ts

packages/core/src/dialects/abstract/query-interface.js

WikiRik

Looks good to me. I'll give some time for @ephys to look at it again before we merge

Outdated

evanrittenhouse force-pushed the query_interface_typescript branch from 9cf14fd to bbf15dd Compare December 25, 2022 21:04

WikiRik reviewed Dec 25, 2022

View reviewed changes

src/dialects/abstract/query-interface.js Outdated Show resolved Hide resolved

WikiRik reviewed Dec 26, 2022

View reviewed changes

src/dialects/abstract/query-interface-typescript.ts Outdated Show resolved Hide resolved

WikiRik reviewed Dec 30, 2022

View reviewed changes

test/integration/query-interface/schemas.test.ts Outdated Show resolved Hide resolved

WikiRik reviewed Jan 3, 2023

View reviewed changes

WikiRik reviewed Jan 9, 2023

View reviewed changes

test/integration/query-interface/schemas.test.ts Outdated Show resolved Hide resolved

evanrittenhouse force-pushed the query_interface_typescript branch from 2ac43a7 to ad61127 Compare January 10, 2023 04:10

evanrittenhouse marked this pull request as ready for review January 10, 2023 06:20

evanrittenhouse requested a review from a team January 10, 2023 06:20

WikiRik reviewed Jan 10, 2023

View reviewed changes

evanrittenhouse force-pushed the query_interface_typescript branch 2 times, most recently from 02ea0bb to 51eda04 Compare January 12, 2023 02:14

WikiRik reviewed Jan 14, 2023

View reviewed changes

ephys self-requested a review January 14, 2023 17:03

ephys previously requested changes Jan 14, 2023

View reviewed changes

evanrittenhouse force-pushed the query_interface_typescript branch 2 times, most recently from fb35ccd to a22dbd8 Compare January 15, 2023 20:21

WikiRik reviewed Jan 15, 2023

View reviewed changes

test/integration/query-interface/schemas.test.ts Outdated Show resolved Hide resolved

evanrittenhouse force-pushed the query_interface_typescript branch from a22dbd8 to 3c8722b Compare January 16, 2023 02:13

WikiRik reviewed Jan 16, 2023

View reviewed changes

packages/core/src/dialects/abstract/query-generator.types.ts Outdated Show resolved Hide resolved

packages/core/test/integration/query-interface/schemas.test.ts Outdated Show resolved Hide resolved

evanrittenhouse force-pushed the query_interface_typescript branch 4 times, most recently from 131c2ce to c65ce08 Compare January 17, 2023 00:13

evanrittenhouse force-pushed the query_interface_typescript branch from fdea3f5 to f843b1c Compare February 2, 2023 16:08

WikiRik reviewed Feb 2, 2023

View reviewed changes

packages/core/test/integration/query-interface.test.js Outdated Show resolved Hide resolved

WikiRik reviewed Feb 2, 2023

View reviewed changes

packages/core/src/dialects/abstract/query-interface.d.ts Outdated Show resolved Hide resolved

packages/core/src/dialects/abstract/query-interface.js Outdated Show resolved Hide resolved

WikiRik requested a review from ephys February 2, 2023 17:28

WikiRik previously approved these changes Feb 2, 2023

View reviewed changes

evanrittenhouse added 18 commits February 10, 2023 20:21

Migrate the rest of QI schema methods to TS

da9915c

Fix yarn test-typings

a73f74e

Fix tests that failed on GH

fae5ff0

Remove missed schema method calls

9c54cfc

Pass options to dropSchema

2cb652e

Properly implement skip logic

9d512a7

Fix failures

bedd0a7

Fix integration tests again

fc7976b

Force test cases to use the test database after recreating it

7e1825a

Fix reviewer comments

d93e761

Implement docs changes

5549364

Implement reviewer comments on tests

84b4f52

Change queryGenerator.dropSchemaQuery() typing

43995a9

Remove nesting and change imports for the monorepo

377cb59

Fix typing issues, part 2

0ab95ae

This just worked

0fd0953

Remove dropAllSchemas from TS QI

e9516e2

Add QI type

a1a1357

evanrittenhouse force-pushed the query_interface_typescript branch from 3f6bce9 to a1a1357 Compare February 11, 2023 02:21

WikiRik dismissed their stale review via a1a1357 February 11, 2023 09:56

Merge branch 'main' into query_interface_typescript

f0c48f0

Merge branch 'main' into query_interface_typescript

ddd83be

evanrittenhouse requested a review from WikiRik February 15, 2023 18:17

WikiRik approved these changes Feb 16, 2023

View reviewed changes

WikiRik merged commit a785609 into sequelize:main Feb 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migrate the rest of QI `schema` methods to TS #15498

feat: Migrate the rest of QI `schema` methods to TS #15498

evanrittenhouse commented Dec 25, 2022

WikiRik left a comment

evanrittenhouse commented Dec 26, 2022

WikiRik left a comment

evanrittenhouse commented Jan 9, 2023

evanrittenhouse commented Jan 10, 2023

WikiRik commented Jan 10, 2023

WikiRik left a comment

WikiRik left a comment

WikiRik left a comment

evanrittenhouse commented Feb 1, 2023

WikiRik left a comment

WikiRik left a comment

feat: Migrate the rest of QI schema methods to TS #15498

feat: Migrate the rest of QI schema methods to TS #15498

Conversation

evanrittenhouse commented Dec 25, 2022

Pull Request Checklist

Description Of Change

WikiRik left a comment

Choose a reason for hiding this comment

evanrittenhouse commented Dec 26, 2022

WikiRik left a comment

Choose a reason for hiding this comment

evanrittenhouse commented Jan 9, 2023

evanrittenhouse commented Jan 10, 2023

WikiRik commented Jan 10, 2023

WikiRik left a comment

Choose a reason for hiding this comment

WikiRik left a comment

Choose a reason for hiding this comment

WikiRik left a comment

Choose a reason for hiding this comment

evanrittenhouse commented Feb 1, 2023

WikiRik left a comment

Choose a reason for hiding this comment

WikiRik left a comment

Choose a reason for hiding this comment

feat: Migrate the rest of QI `schema` methods to TS #15498

feat: Migrate the rest of QI `schema` methods to TS #15498