feat!: make generated association names lowerCamelCase by default #16514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not related to your change, but I had to manually cancel the DB2 tests. Check out the timestamps; and compare that to postgres; Should be an easy fix with how we run db2 tests compared to the others, but wanted to comment it somewhere before I forget |
WikiRik
approved these changes
Jan 31, 2024
|
@ephys I'll let you merge this one |
|
Hi, could you please look this issue. Might be related to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This PR makes association names generated by Sequelize be camelCase instead of PascalCase by default.
Until now, the name of the association was the name (plural or singular, depending) of the target model.
Our documentation uses PascalCase for model names (as they are JS classes) and camelCase for association names & attributes (as they are class fields).
Using the model name as the association name broke that convention, so the new implementation turns it into camelCase.
This is a breaking change, we will need to document that