Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add unit test for ARRAY(UUID) #16841

Merged
merged 1 commit into from
Dec 12, 2023
Merged

meta: add unit test for ARRAY(UUID) #16841

merged 1 commit into from
Dec 12, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Dec 6, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Support for this was likely added in the big DataTypes PR, but it was not tested before. This was requested in #10321
The docs just mention that DataTypes.Something can be used so no need to update those; https://sequelize.org/docs/v7/models/data-types/#arrays

@WikiRik WikiRik requested a review from a team December 6, 2023 08:52
@WikiRik WikiRik added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit d9923a1 Dec 12, 2023
51 checks passed
@WikiRik WikiRik deleted the WikiRIk/array-uuid branch December 12, 2023 11:06
papandreou added a commit to papandreou/sequelize that referenced this pull request Dec 19, 2023
@papandreou
Merge tag 'v7.0.0-alpha.34' into sequelize-core-papandreou2
f02fb95 
v7.0.0-alpha.34

* tag 'v7.0.0-alpha.34': (94 commits)
  v7.0.0-alpha.34
  feat!: rename association classes to prevent conflicts with decorators (sequelize#16513)
  meta: add unit test for ARRAY(UUID) (sequelize#16841)
  fix: correct link to data types docs (sequelize#16674)
  feat: add support for `sql` tag & functions in `sequelize.query` (sequelize#16863)
  feat: add an option to control the behavior of `null` in JSON attributes (sequelize#16861)
  meta: update dependency nx to v17.2.1 (sequelize#16862)
  meta: update sequelize AUTHORS (sequelize#16856)
  meta: lock file maintenance (sequelize#16859)
  meta: update dependency typedoc-plugin-mdn-links to v3.1.7 (sequelize#16857)
  meta: update dependency markdownlint-cli to v0.38.0 (sequelize#16854)
  meta: update dependency nx to v17.2.0 (sequelize#16853)
  meta: update dependency ts-node to v10.9.2 (sequelize#16852)
  meta: update dependency @types/snowflake-sdk to v1.6.20 (sequelize#16850)
  meta: update dependency @types/snowflake-sdk to v1.6.19 (sequelize#16849)
  meta: update actions/stale action to v9 (sequelize#16847)
  meta: update dependency snowflake-sdk to v1.9.2 (sequelize#16846)
  meta: update dependency @types/node to v20.10.4 (sequelize#16845)
  meta: add tests to verify that showConstraints filters on schema (sequelize#16785)
  meta: update sequelize AUTHORS (sequelize#16781)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WikiRik @ephys