Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix NOT operator sometimes producing incorrect queries #17044

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix: fix NOT operator sometimes producing incorrect queries #17044

merged 2 commits into from
Feb 5, 2024

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Feb 4, 2024

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Fixes #16437

@WikiRik WikiRik requested a review from ephys February 4, 2024 16:56
@WikiRik WikiRik marked this pull request as ready for review February 4, 2024 17:31
@ephys ephys changed the title fix: remove unneeded SQL optimalization fix: remove NOT operator sometimes producing incorrect queries Feb 5, 2024
@ephys ephys added this pull request to the merge queue Feb 5, 2024
@ephys ephys removed this pull request from the merge queue due to a manual request Feb 5, 2024
@ephys ephys changed the title fix: remove NOT operator sometimes producing incorrect queries fix: fix NOT operator sometimes producing incorrect queries Feb 5, 2024
@ephys ephys added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 63ba367 Feb 5, 2024
53 checks passed
@ephys ephys deleted the WikiRik/16437 branch February 5, 2024 07:59
@amoqaddam
Copy link

I tested this on version 7.0.0-alpha.36
But unfortunately, the problem still exists and generate exactly same output (#16437 )

@ephys
Copy link
Member

ephys commented Feb 5, 2024

Hey :)
This change was not released yet, 7.0.0-alpha.36 is from a few days ago

@amoqaddam
Copy link

Hey :) This change was not released yet, 7.0.0-alpha.36 is from a few days ago

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NOT Operator does not work properly in deep "WHERE" conditions in version 7
3 participants
@WikiRik @amoqaddam @ephys