-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ModelRepository#_UNSTABLE_bulkDestroy
and manual ON DELETE
handling
#17078
Conversation
There are still a few TODOs and commented out code here. Is that all going to be fixed when |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plenty of TODOs, but it's better to merge this now instead of having it blocked for a while.
Pull Request Checklist
Description Of Change
This PR introduces
ModelRepository#_UNSTABLE_bulkDestroy
, as part of the migration to repositories & general rewrite ofModel
This PR also introduces the
manualOnDelete
option in both_UNSTABLE_bulkDestroy
and_UNSTABLE_destroy
.This PR only implements that part of the code that relies on
DELETE
queries, as the rest will require implementing_UNSTABLE_update
first, which depends on #17063Closes #2586