Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a missing period in findOrCreate tsdoc #17127

Merged
merged 2 commits into from
Apr 4, 2024
Merged

docs: add a missing period in findOrCreate tsdoc #17127

merged 2 commits into from
Apr 4, 2024

Conversation

Navid079
Copy link
Contributor

@Navid079 Navid079 commented Feb 27, 2024 •
edited
Loading

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

I added a single period in tsdocs of findOrCreate method because it was really confusing for me when I read it.

List of Breaking Changes

@Navid079 Navid079 requested a review from a team as a code owner February 27, 2024 12:41
@Navid079 Navid079 changed the title add the missing period in findOrCreate tsdoc (docs) add the missing period in findOrCreate tsdoc Feb 27, 2024
@Navid079 Navid079 changed the title (docs) add the missing period in findOrCreate tsdoc docs: add the missing period in findOrCreate tsdoc Feb 27, 2024
@ephys ephys changed the title docs: add the missing period in findOrCreate tsdoc docs: add a missing period in findOrCreate tsdoc Apr 4, 2024
@ephys ephys enabled auto-merge (squash) April 4, 2024 13:06
@ephys ephys merged commit c89f22e into sequelize:main Apr 4, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik Awaiting requested review from WikiRik WikiRik is a code owner automatically assigned from sequelize/code-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Navid079 @ephys