Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mssql): upgrade to tedious 18 #17137

Merged
merged 3 commits into from
Mar 26, 2024
Merged

feat(mssql): upgrade to tedious 18 #17137

merged 3 commits into from
Mar 26, 2024

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 2, 2024

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

Tedious 18 now ships with first-party typings so we can remove @types/tedious.

Drafting this for now since I want to check what we've put in the docs for TypeScript usage of mssql.
EDIT: This will be done as part of the documentation surrounding the dialect extraction

List of Breaking Changes

People that use TypeScript should upgrade to v18 as well. And they can remove @types/tedious

@WikiRik
Copy link
Member Author

WikiRik commented Mar 18, 2024

This is ready to be reviewed, but not for merging yet since I still need to check docs

@WikiRik WikiRik marked this pull request as ready for review March 18, 2024 11:11
@WikiRik WikiRik requested a review from a team as a code owner March 18, 2024 11:11
@WikiRik
Copy link
Member Author

WikiRik commented Mar 25, 2024

@lohart13 what do you think, shall I rebase this once you have extracted @sequelize/mssql away?

@lohart13
Copy link
Contributor

@WikiRik if you're ready to merge this, go ahead. The mssql split is still WIP.

@ephys ephys changed the title fix(mssql): upgrade to tedious 18 feat(mssql): upgrade to tedious 18 Mar 26, 2024
@WikiRik WikiRik requested a review from ephys March 26, 2024 16:22
@WikiRik WikiRik merged commit 65e19a1 into main Mar 26, 2024
54 checks passed
@WikiRik WikiRik deleted the WikiRik/tedious-18 branch March 26, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants