Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mysql)!: move mysql to the @sequelize/mysql package #17202

Merged
merged 3 commits into from Mar 25, 2024
Merged

feat(mysql)!: move mysql to the @sequelize/mysql package #17202

merged 3 commits into from Mar 25, 2024

Conversation

lohart13
Copy link
Contributor

Goal of the PR

Related issue: #13722
Related PR: #17190

This PR moves the MySql Dialect to the @sequelize/mysql package.

Relevant impacts

  • This package pre-installs the necessary mysql-specific dependency mysql. Users won't need to install the additional packages anymore. This gives us control over which version we support.
  • Unlike the postgres package, this package does not have unit tests yet. Once we add those, the script should be added to the package package.json and CI.

Other changes

Breaking changes

  • Instead of installing mysql2 users need to install @sequelize/mysql.

@lohart13 lohart13 requested a review from a team as a code owner March 25, 2024 10:51
@lohart13 lohart13 requested review from ephys and WikiRik March 25, 2024 10:51
ephys
ephys reviewed Mar 25, 2024
View reviewed changes
packages/mysql/src/index.mjs Outdated Show resolved Hide resolved
WikiRik
WikiRik approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocking remark

packages/core/test/unit/query-interface/create-table.test.ts Show resolved Hide resolved
@ephys ephys merged commit 5c7830e into sequelize:main Mar 25, 2024
49 checks passed
@lohart13 lohart13 deleted the split-mysql branch March 25, 2024 20:25
@ephys ephys mentioned this pull request Mar 26, 2024
Open
@ephys ephys mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lohart13 @ephys @WikiRik