feat(snowflake)!: move snowflake to the @sequelize/snowflake package
#17207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohart13
commented
Mar 26, 2024
lohart13
changed the title
@sequelize/snowflake package
WikiRik
reviewed
Mar 26, 2024
lohart13
force-pushed
the
split-snowflake
branch
2 times, most recently
from
9fb1c69
to
ab176e8
Compare
WikiRik
approved these changes
Mar 26, 2024
lohart13
force-pushed
the
split-snowflake
branch
from
ab176e8
to
9714a47
Compare
|
@lohart13 Thanks again for all the work you've put in for sequelize in general and for getting these dialects extracted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of the PR
Related issue: #13722
Related PR: #17190
This PR moves the Snowflake Dialect to the
@sequelize/snowflakepackage.Relevant impacts
snowflake. Users won't need to install the additional packages anymore. This gives us control over which version we support.Other changes
Breaking changes
snowflake-sdkusers need to install@sequelize/snowflake.