-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add experimentalDecorators support for sscce #17208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see other usages of this tsconfig that could break when adding experimentalDecorators so I think we're good. Will wait for Zoé to make sure, maybe I missed something.
Shall we add yarn sscce-sqlite
(since we can run that in-memory) to the CI to make sure the SSCCE works?
Do you want the test separate similar to the SQLite tests on windows or it on each dialect before the integration tests? |
Similar to SQLite tests, I think if it runs on one dialect it also works on the others. But we need to run it as an integration test so sqlite is the easiest |
f17f78f
to
12689ca
Compare
OK, I've added this now. |
It doesn't really matter in my opinion, this is fine |
Note if we're just running it on sscce, it could be part of the unit suite? It's not a unit test because it requires an actual database but it removes the checkout, node, download etc steps for what is a 1 second test |
I agree, this makes sense and should same sometime on the CI. |
Head branch was pushed to by a user without write access
dbc2f1f
to
6ce01bf
Compare
Updated now. |
Pull Request Checklist
Description of Changes
Add
"experimentalDecorators": true
to the root tsconfig so that thesscce.ts
file can be run.