Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add experimentalDecorators support for sscce #17208

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

lohart13
Copy link
Contributor

Pull Request Checklist

  • [] Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

Add "experimentalDecorators": true to the root tsconfig so that the sscce.ts file can be run.

@lohart13 lohart13 requested a review from a team as a code owner March 26, 2024 04:55
@lohart13 lohart13 requested review from ephys and WikiRik March 26, 2024 04:55
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see other usages of this tsconfig that could break when adding experimentalDecorators so I think we're good. Will wait for Zoé to make sure, maybe I missed something.

Shall we add yarn sscce-sqlite (since we can run that in-memory) to the CI to make sure the SSCCE works?

@lohart13
Copy link
Contributor Author

Shall we add yarn sscce-sqlite (since we can run that in-memory) to the CI to make sure the SSCCE works?

Do you want the test separate similar to the SQLite tests on windows or it on each dialect before the integration tests?

@WikiRik
Copy link
Member

WikiRik commented Mar 26, 2024

Similar to SQLite tests, I think if it runs on one dialect it also works on the others. But we need to run it as an integration test so sqlite is the easiest

@lohart13
Copy link
Contributor Author

lohart13 commented Mar 26, 2024

OK, I've added this now.
Edit: should the test-sscce run after all the unit and typings test but before the integration?

@WikiRik
Copy link
Member

WikiRik commented Mar 26, 2024

Edit: should the test-sscce run after all the unit and typings test but before the integration?

It doesn't really matter in my opinion, this is fine

@WikiRik WikiRik enabled auto-merge (squash) March 26, 2024 23:38
@ephys
Copy link
Member

ephys commented Mar 26, 2024

Note if we're just running it on sscce, it could be part of the unit suite? It's not a unit test because it requires an actual database but it removes the checkout, node, download etc steps for what is a 1 second test

@lohart13
Copy link
Contributor Author

Note if we're just running it on sscce, it could be part of the unit suite? It's not a unit test because it requires an actual database but it removes the checkout, node, download etc steps for what is a 1 second test

I agree, this makes sense and should same sometime on the CI.

auto-merge was automatically disabled March 27, 2024 00:04

Head branch was pushed to by a user without write access

@lohart13
Copy link
Contributor Author

Note if we're just running it on sscce, it could be part of the unit suite? It's not a unit test because it requires an actual database but it removes the checkout, node, download etc steps for what is a 1 second test

I agree, this makes sense and should same sometime on the CI.

Updated now.
I also added test to the test-windows

@WikiRik WikiRik enabled auto-merge (squash) March 27, 2024 00:05
@WikiRik WikiRik merged commit 4025d17 into sequelize:main Mar 27, 2024
49 checks passed
@lohart13 lohart13 deleted the update-tsconfig branch March 27, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants