Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: rename ./dialects/abstract to ./abstract-dialect #17216

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 27, 2024

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

This PR moves the abstract dialect files to a higher level folder named abstract-dialect.

Only change not directly related to renaming the folder and updating imports is in packages/core/test/support.ts. That change is made possible because all natively supported dialects have their own package now.

@WikiRik WikiRik requested a review from a team as a code owner March 27, 2024 20:25
@WikiRik WikiRik requested a review from ephys March 27, 2024 20:25
@WikiRik WikiRik enabled auto-merge (squash) March 27, 2024 20:38
@WikiRik WikiRik merged commit aeff90c into main Mar 27, 2024
51 of 55 checks passed
@WikiRik WikiRik deleted the WikiRik/13772-1 branch March 27, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants