Issue 17232 - sql.trim() fatal error #17233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
requested changes
Apr 1, 2024
There was a problem hiding this comment.
This is not a safe solution for this problem. Instead of silently returning null we should throw an error explaining what was passed as sql.
Furthermore; I don't think this will solve your original issue. You mentioned that your project does not make use of sequelize.query() so the actual root cause is in one of the other functions. Can you update your original issue with at least the full stacktrace so we can see if we can help you out further?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
fix - #17232 - sql.trim() fatal error