New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some data types in mssql and postgres #3836

Merged
merged 2 commits into from Jun 1, 2015

Conversation

4 participants
@BridgeAR
Contributor

BridgeAR commented May 31, 2015

This fixes the issue found in #3827

@BridgeAR BridgeAR referenced this pull request May 31, 2015

Merged

Type warnings #3839

@BridgeAR

This comment has been minimized.

Contributor

BridgeAR commented May 31, 2015

I added support for TEXT('length'). This fixes #2793 and #3435

Ruben Bridgewater
@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Jun 1, 2015

@BridgeAR In the future please reference issues from the commits, makes the history much nicer.

mickhansen added a commit that referenced this pull request Jun 1, 2015

Merge pull request #3836 from BridgeAR/fix-types
Fix some data types in mssql and postgres

@mickhansen mickhansen merged commit 8a6c1a5 into sequelize:master Jun 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BridgeAR

This comment has been minimized.

Contributor

BridgeAR commented Jun 1, 2015

@mickhansen I stopped inserting the issues in the commit message because it'll reference the ticket with a new commit each time I rebase ;). So I referenced them once in here (I might have edited that comment though)?

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Jun 1, 2015

@BridgeAR Comments don't close tickets though and it's still way nicer being able to see issues form the commit history without having to find the original PR :)

But yeah it's annoying if it creates a new reference with each rebase.

@jehoshua02

This comment has been minimized.

@janmeier

This comment has been minimized.

Member

janmeier commented Jul 11, 2016

@jehoshua02 which options are missing? He tiny option is already shown. You can also just open a PR with the changes you'd like to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment