option object shouldn't be updated internally. #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr is for the following bug. |
| @@ -477,7 +477,7 @@ Instance.prototype.save = function(options) { | |||
| if (arguments.length > 1) { | |||
| throw new Error('The second argument was removed in favor of the options object.'); | |||
| } | |||
| options = _.defaults(options || {}, { | |||
| options = _.defaults({}, options || {}, { | |||
There was a problem hiding this comment.
I don't think we need options || {}, options should be fine
|
Looks good @smihica - do you mind adding a few tests. Preferrably unit tests, since they are faster. Something along the lines of stub(sequelize, 'query').returns(Promise.resolve([]));
var options = { ... }
model.reload(options);
expect(options).to.deep.equal({... }If you have too many problems trying to stub sequelize.query, integration tests that hit the db will be fine as well |
|
Yes, I'll try to add some tests later. thanks reviewing. |
|
@janmeier |
janmeier
added a commit
that referenced
this pull request
Aug 4, 2015
option object shouldn't be updated internally.
|
Solid work on the tests @smihica ! Thanks for this, and the other PR also :) |
janmeier
added a commit
that referenced
this pull request
Aug 4, 2015
This was referenced Aug 4, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got "not-null constraint" error because the previous save(opt) call inserted "fields" into opt.
This may cause confusing errors.