skip other validations if allowNull is true and value is null #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uhm if I don't miss something you should check for |
|
Pretty sure Perhaps you could check for the value being strictly true, but the logic seems right to me. |
|
ah. now I got it. |
|
I'm not sure there's a need to strictly check for boolean true. Checking for anything truthy would be my expected behaviour, I think. Up to the maintainers -- I can amend if need be. |
|
I've just rebased this branch onto the current master. |
|
Implemented in #601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #270 and #118. I added tests (first ones I've ever written, so I hope they're okay) which pass, and no other tests were compromised.