Fix #5880, deletedAt compare against NOW #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mickhansen @janmeier, Please have a look when you get chance. CI is clear except of one timeout error. |
|
Sweet! :) |
|
Notice that this PR is on the 4.0 branch - You are welcome to make a PR to v3 as well, then I'll publish a new version |
|
I am currently using my sequelize fork in my projects so I can wait till 4.0 is release. If any one else need this update in current semversion let me know and I will push it to v3 as well. |
Wsiegenthaler
added a commit
to Wsiegenthaler/sequelize
that referenced
this pull request
Feb 25, 2017
Wsiegenthaler
added a commit
to Wsiegenthaler/sequelize
that referenced
this pull request
Feb 25, 2017
Wsiegenthaler
added a commit
to Wsiegenthaler/sequelize
that referenced
this pull request
Feb 25, 2017
Wsiegenthaler
added a commit
to Wsiegenthaler/sequelize
that referenced
this pull request
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Futurein the changelog?Description of change
Closes #5880 ,
deletedAtfield is compared againstCURRENT_TIMESTAMPrather thanIS NULL. It also check forIS NULLin casedeletedAtis not set at all.