Include tableName in MySQL fk contraint names

[hagabaka]

Pull Request check-list

• Does npm run test or npm run test-DIALECT pass with this change (including linting)?
• Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
• Have you added new tests to prevent regressions?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Have you added an entry under Future in the changelog?

Description of change

When creating a foreign key constraint in MySQL, use the template
{referring_table}_{attribute}_foreign_idx, rather than just
{attribute}_foreign_idx, to avoid duplicate constraint names.

See GitHub #5826

[mickhansen]

LGTM, /cc @janmeier

[danielepolencic]

any chance this could be released?

[mickhansen]

@danielepolencic This PR targeted master so it's slated for the next 4.0 pre release.

[eliias]

@mickhansen any chance of backporting this to 3.x? As it is impossible to set the name of the constraint, only raw SQL is left for the rescue.

[felixfbecker]

Isnt this a beaking change?

[mickhansen]

@felixfbecker I don't believe so since we don't really depend on constraint names anywhere.
@eliias It's very unlikely that the core team will get around to that, but a PR is certainly welcome.

[felixfbecker]

@mickhansen we don't, but a user might (think raw queries in migration files, etc). It's like changing the default casing of table names.

[mickhansen]

@felixfbecker That is true

[felixfbecker]

@eliias it will land in v4

[diosney]

It is really sad that we have to wait until v4 for this.

In the meantime, as a workaround, I'm setting the column to be something like ModeNameColumnName.

If you find a nicer workaround please share it!

[blackrabbit99]

Thank you for breaking changes!

[jramos-br]

This problem also affects mssql dialect. Any plans to change it there?