Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeAttribute('id') results in undefined: null data value (#7318) #7382

Merged
merged 7 commits into from
Mar 20, 2017

Conversation

boltosaurus
Copy link

Fix for Issue #7318 - removeAttribute('id') results in undefined: null data value (#7318)
Added regression test for the fix

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #7382 into master will not change coverage.
The diff coverage is 100%.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167194...160b5fd. Read the comment docs.

changelog.md Outdated
@@ -56,6 +56,7 @@
- [FIXED] Connection error when fetching OIDs for unspported types in Postgres 8.2 or below [POSTGRES] [#5254](https://github.com/sequelize/sequelize/issues/5254)
- [FIXED] Expose OptimisticLockError on Sequelize object [#7291](https://github.com/sequelize/sequelize/pull/7291)
- [FIXED] Deleted paranoid records can be queried in the same second. [#7204](https://github.com/sequelize/sequelize/issues/7204)/[#7332](https://github.com/sequelize/sequelize/pull/7332)
- [FIXES] `removeAttribute('id')` results in `undefined: null` data value [#7318] https://github.com/sequelize/sequelize/issues/7318

Copy link

@harshithkashyap harshithkashyap Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change FIXES to FIXED

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@boltosaurus
Copy link
Author

Done

@sushantdhiman sushantdhiman merged commit b53bae5 into sequelize:master Mar 20, 2017
mkaufmaner pushed a commit to mkaufmaner/sequelize that referenced this pull request Apr 25, 2017
…ze#7318) (sequelize#7382)

* issue # 7318

fixes issue # 7318 - sequelize#7318

* test and change log

* formatting

* changed message

* Update changelog.md

* Update removeAttribute.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants