Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statement_timeout): Support for PostgreSQL statement_timeout #8254

Closed
wants to merge 10 commits into from
Closed

Conversation

jkennedy1980
Copy link

I just contributed statement_timeout support to node-pg in version 7.3.0. This PR brings statement_timeout support to Sequelize.

Statement timeout allows you to set a maximum milliseconds for all queries executed on a connection. This is useful when running on Heroku because they enforce a maximum HTTP timeout of 30 seconds. If you have long running queries, postgres continues to execute them even though the HTTP connection is closed and no one will receive the response.

@jkennedy1980 jkennedy1980 changed the title Support for PostgreSQL statement_timeout feat(statement_timeout): Support for PostgreSQL statement_timeout Sep 5, 2017
@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #8254 into master will decrease coverage by 3.66%.
The diff coverage is n/a.

@sushantdhiman sushantdhiman added dependency For issues and PRs. Things that are related to one or more dependencies. dialect: postgres For issues and PRs. Things that involve PostgreSQL (and do not involve all dialects). labels Sep 7, 2017
@sushantdhiman
Copy link
Contributor

Added this option to whitelist here https://github.com/sequelize/sequelize/pull/8342/files

Any pg@7.3 users can now use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency For issues and PRs. Things that are related to one or more dependencies. dialect: postgres For issues and PRs. Things that involve PostgreSQL (and do not involve all dialects).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants