fix(errors): spurious Bluebird warnings #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way Sequelize instantiates some of its Error subclasses confuses Bluebird into thinking that Promises are rejected with non-Error objects. See petkaantonov/bluebird#990
gabegorelick
commented
Oct 2, 2017
| @@ -11,7 +11,6 @@ class BaseError extends Error { | |||
| constructor(message) { | |||
| super(message); | |||
| this.name = 'SequelizeBaseError'; | |||
| this.message = message; | |||
There was a problem hiding this comment.
The super class should already set this.message = message. The only slight API change is if clients relied on Sequelize's behavior of not defaulting message to '', which Error does.
Note that Sequelize wasn't totally consistent in this regard, since ValidationErrorItem.message defaulted to ''.
There was a problem hiding this comment.
ECMAScript specs says error messages should default to empty string where we are setting them to undefined.
Bluebird's error check also conforms to this, but it would be better if they also include instance of check as undefined error message very much is possible in everyday code.
janmeier
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
The way Sequelize instantiates some of its Error subclasses confuses Bluebird into thinking that Promises are rejected with non-Error objects, so you get warnings when running with
BLUEBIRD_DEBUGenabled.See petkaantonov/bluebird#990