Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): native getter is triggered on cloning sequelize #9551

Closed
wants to merge 1 commit into from

Conversation

sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #3781

#3781 (comment)

I have verified its working with following code, this can't be tested in CI as we always have pg-native dependency installed

const Sequelize = require('sequelize');
const { cloneDeep } = require('lodash');

const sequelize = new Sequelize({
  dialect: 'postgres'
});

cloneDeep(sequelize);

@Ricardonacif
Copy link

Ricardonacif commented Mar 25, 2019

Why was this issue closed? I can still reproduce it on the latest version of Sequelize. It's a weird issue because it messes with the process somehow. Just after the message Cannot find module 'pg-native' appear, I start to get socket hangup on other parts of the code not related to where I was calling sequelize stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants