Skip to content

fix(clear-changed-after-reload): 'changed()' was not returning false … - #9615

Merged
sushantdhiman merged 2 commits into
sequelize:masterfrom
mirkojotic:changed-should-be-false-after-reload
Jul 3, 2018
Merged

sushantdhiman merged 2 commits into
sequelize:masterfrom
mirkojotic:changed-should-be-false-after-reload

Conversation

@mirkojotic

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

After changing of attributes and calling reload(), changed() was still returning changed attributes #9594

@codecov

codecov Bot commented Jun 28, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #9615 into master will increase coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman
sushantdhiman requested a review from a team July 3, 2018 15:54
@sushantdhiman
sushantdhiman merged commit d65cc7b into sequelize:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants