Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(belongs-to): create now returns target model #9980

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@Munter
Copy link
Contributor

@Munter Munter commented Oct 2, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #8716

@codecov
Copy link

@codecov codecov bot commented Oct 2, 2018

Codecov Report

Merging #9980 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9980      +/-   ##
==========================================
+ Coverage   96.38%   96.38%   +<.01%     
==========================================
  Files          63       63              
  Lines        9388     9389       +1     
==========================================
+ Hits         9049     9050       +1     
  Misses        339      339
Impacted Files Coverage Δ
lib/associations/has-one.js 97.11% <ø> (ø) ⬆️
lib/associations/belongs-to.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053145c...0aaf09a. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 07fe591 into sequelize:master Oct 2, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 96.38%)
Details
@codecov
codecov/project 96.38% (+<.01%) compared to 053145c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 2, 2018

Thanks @Munter

@Munter Munter deleted the Munter:fix-8716 branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants