test: convert storage tests to typescript #217
Conversation
test/storages/sequelize.test.ts
Outdated
| expect(description).toMatchInlineSnapshot(` | ||
| Object { | ||
| "name": Object { | ||
| "allowNull": false, | ||
| "defaultValue": undefined, | ||
| "primaryKey": true, | ||
| "type": "VARCHAR(255)", | ||
| }, | ||
| } | ||
| `); |
There was a problem hiding this comment.
Looks like you forgot to fix this last line in your use tabs commit (b840f0e)
Also, by the way, I'm curious - does Jest automatically outdents the inline snapshot?
There was a problem hiding this comment.
Good catch - and yes jest is supposed to handle this automatically, but I think I need to tweak some of the lint config so it can tell that we like tabs over spaces. I'll do that in another PR and fix this one manually.
| }); | ||
|
|
||
| return storage.executed().then(migrations => { | ||
| expect(Object.keys(migrations)).toHaveLength(0); |
There was a problem hiding this comment.
Just out of curiosity - wouldn't expect(migrations).toEqual({}) work?
There was a problem hiding this comment.
Yes it probably would - this file is a straight up port, I just ran jest-codemods and cleaned up some of the context variables, I didn't touch any of the assertions.
Agreed |
This moves the storage tests out of legacy-tests and into typescript/jest-land.
There are some changes I want to make to a few of the storage helpers, and how
Umzugis passed them, so I wanted to get them tested with the new system first. I think some of them could be dropped and replaced with integration tests, long term: