fix: import sequelize as a type #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also ignore errors when importing, so users not using sequelize storage don't hit typescript errors
papb
reviewed
Oct 15, 2020
.eslintrc.js
Outdated
| @@ -34,7 +34,7 @@ module.exports = { | |||
| 'jest/expect-expect': ['error', { assertFunctionNames: ['expect', 'expectTypeOf', 'verify'] }], | |||
|
|
|||
| '@typescript-eslint/ban-types': 'off', | |||
| '@typescript-eslint/ban-ts-comment': ['warn', { 'ts-expect-error': false }], | |||
| '@typescript-eslint/ban-ts-comment': 'off', // covered by prefer-ts-expect-error | |||
There was a problem hiding this comment.
I think '@typescript-eslint/ban-ts-comment' checks more things than just @ts-ignore and @ts-expect-error, doesn't it?
There was a problem hiding this comment.
You're right. I've changed this to allow ts-ignore and ts-expect-error only with explanations. Even though ts-ignore is whitelisted, prefer-ts-expect-error will still complain if you try to use it, so to use ts-ignore you need an explanation and a eslint-disable-next-line. Which is a good thing IMO, ts-ignore is dangerous and should only be used rarely!
now allow with descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also ignore errors when importing, so users not using sequelize storage don't hit typescript errors
Fixes #348