Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed v2 migration snippet #380

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Completed v2 migration snippet #380

merged 1 commit into from
Nov 16, 2020

Conversation

MichielDeMey
Copy link
Contributor

I believe that for the migration snippet to be 100% complete, we should also pass the name to the return value,
otherwise you might end up with an error:

SequelizeValidationError: notNull Violation: SequelizeMeta.name cannot be null

@mmkal mmkal merged commit 38cb2bc into sequelize:master Nov 16, 2020
@mmkal
Copy link
Contributor

mmkal commented Nov 16, 2020

Thanks @MichielDeMey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichielDeMey @mmkal