Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarning for Sequelize V7 #644

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

anroypaul
Copy link
Contributor

This PR is fixing DeprecationWarning for Sequelize V7 (currently alpha, warning [SEQUELIZE0010]): Accessing DataTypes on the Sequelize constructor is deprecated. Use the DataTypes object instead.

Reference to Sequelize V7 upgrade.

…quelize constructor is deprecated. Use the DataTypes object instead.
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTypes.STRING does also exist for v6 so this is not a breaking change or anything

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69bb341) 99.43% compared to head (31fe192) 99.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          12       12           
  Lines        1422     1422           
  Branches      257      257           
=======================================
  Hits         1414     1414           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmkal mmkal merged commit bc9ab35 into sequelize:main Jan 26, 2024
5 checks passed
Copy link

Released in v3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants