docs: thoroughly document DataTypes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the lint issue but feel free to review the contents :) |
6 tasks
sdepold
reviewed
Mar 17, 2022
Ah nevermind. Cool stuff |
sdepold
previously approved these changes
Mar 17, 2022
They're two new components that can be used in mdx files:
Edit: ah, I'm too late :) |
|
Before merging I've noticed the two first datatype sections don't have links to the dialect documentations like the other ones. I should fix that. |
…te into ephys/new-datatypes-docs
|
Links to the different dbms documentations have been added IMO we can merge without @markdirish's review for db2/ibmi. We'll open a follow-up PR if necessary |
|
lgtm |
|
conflict fixed |
sdepold
approved these changes
Mar 19, 2022
ephys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the other-data-types page to thoroughly document every built-in DataType, and their corresponding SQL type (per dialect).
I based it on the DataTypes unit tests, as well as the documentation of the different dialects.
I'm unsure which documentation should be used for db2 & ibmi so there are likely errors in what I wrote for these 2 dialects. @markdirish if you have a minute to review this part, and/or point me to the right resources.
I've also documented common pain points, such as DataTypes.UUIDV4 being a JS function instead of a SQL one.
I've also moved the part about querying JSON to the page about Querying (with a link leading there), as that seems to be the place where people look for it.
I wrote a react component that filters out the columns of a table based on the user's preferred dialect :)