remove duplication of verify_num_successful_logins code (#159)

sequentech · Dec 4, 2021 · b69724f · b69724f
1 parent e57de77
commit b69724f
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/authapi/authmethods/m_emailpwd.py b/authapi/authmethods/m_emailpwd.py
@@ -188,15 +188,12 @@ def authenticate(self, auth_event, request, mode='authenticate'):
             return self.authenticate_error("invalid-pipeline", req, auth_event)
 
         if mode == "authenticate":
-            if not verify_num_successful_logins(auth_event, 'OpenIdConnect', user, req):
+            if not verify_num_successful_logins(
+                auth_event, 'EmailPWD', user, req
+            ):
                 return self.authenticate_error(
                     "invalid_num_successful_logins_allowed", req, auth_event
                 )
-            if (auth_event.num_successful_logins_allowed > 0 and
-                user.userdata.successful_logins.filter(is_active=True).count() >= auth_event.num_successful_logins_allowed):
-                return self.authenticate_error(
-                    "invalid_num_successful_logins_allowed", req, auth_event)
-
             return return_auth_data('PWD', req, request, user, auth_event)
 
         LOGGER.debug(\