-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Voting-booth: Support search/filter candidates feature #126
Comments
Hi @ElectricPaperInformationssystemeGmbH could you please review the proposed implementation? |
Hi @Findeton, thanks for the information. The design looks good. We only have one comment on this, it would be handy if we could position the search box left-aligned. We would also like to have the support of asterisk search queries and the search query must run over three parameters: category, text and details. If it is filtered by category, the results should be displayed in one column (answer_group_columns_size: 12, answer_columns_size: 12). |
Hi @ElectricPaperInformationssystemeGmbH Please review the implementation, specifically the section "Actual Implementation with Screenshots". |
The implementation looks good. Reviewed, thank you. |
Preflight checklist
Suggestion
For many candidates, a different display is required (search field at the top and page-by-page display)
Proposed Implementation
show_filter_field
.*
on the filter. For example the textSir John F Kennedy Jr
would match with the searchJohn*Kennedy
.category
,text
ordetails
.Proposed Implementation Design
Actual Implementation with Screenshots
In the implementation we've made a few changes:
.question-search-container { justify-content: flex-start; }
.You can find screenshots below and a link to an election with this feature. Note that this is a development server and how it looks could change.
Empty search field:
Filter by category showing all candidates from the category and using asterisks. As it's filtered by category all is shown in 1 column.
Mobile look:
Filter by write-in content. As it's not filtered by category it's shown in two columns:
Filter by candidate details:
Filter by candidate title/text:
Search for invalid option:
Tasks
Tasks
Master PRs
Additional context
No response
The text was updated successfully, but these errors were encountered: