Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Responsive wraps for high cumulative votes #211

Closed
7 tasks done
markgrafd opened this issue Aug 18, 2023 · 8 comments
Closed
7 tasks done

🐞 Responsive wraps for high cumulative votes #211

markgrafd opened this issue Aug 18, 2023 · 8 comments
Assignees
Labels
bug Something isn't working epi-1 EPI-1 project

Comments

@markgrafd
Copy link

markgrafd commented Aug 18, 2023

Preflight checklist

  • I could not find a solution in the existing issues, docs, nor discussions.

Current Behavior

Many customers have plurality voting with high cumulative numbers for votes. About 50% of these voters vote on mobile devices. Our customers want responsive wraps for the checkboxes on mobile devices, as the display is perceived as "buggy" this way.

image

image

Expected Behavior

The border of the list box should contain all the boxes. The checkboxes should be wrapped so that they display better on mobile devices.

Steps To Reproduce

No response

Environment

- OS:
- Web browser:

Implementation

Below you can find a couple images that show how the voting booth looks once fixed.

Please note that although for very small screens we have limited the default CSS to be a two checkbox per row, you can customize that using theme_css and override and increase the max-width for the checkboxes section to the desired width. The default is [avb-simultaneous-question-answer-v2] .vertilize-col.answer-glyphicon { max-width: 26%; }. You can also use css @media queries to limit the width in bigger screens.

Image
Image

Tasks

Tasks

Master PRs

  1. bug

Stable PRs

  1. bug
  2. bug
  3. bug

Additional context

No response

@markgrafd markgrafd added bug Something isn't working epi-1 EPI-1 project triage needs triage labels Aug 18, 2023
@edulix edulix self-assigned this Aug 22, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 25, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping
in a new rows.
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 25, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a
new rows.
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 25, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a
new rows.
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 25, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a
new rows.
@edulix edulix closed this as completed Aug 25, 2023
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 26, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a new rows.
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 26, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a
new rows. Previous fix was incomplete.
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 26, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a
new rows. Previous fix was incomplete.
edulix added a commit to sequentech/voting-booth that referenced this issue Aug 26, 2023
Parent issue: sequentech/meta#211

Problem solved: checkboxes overflow to the side instead of wrapping in a
new rows. Previous fix was incomplete.
@edulix
Copy link
Contributor

edulix commented Aug 26, 2023

@markgrafd @ElectricPaperInformationssystemeGmbH I added an implementation note in the description, please view/read.

@edulix edulix removed the triage needs triage label Aug 26, 2023
@markgrafd
Copy link
Author

@edulix Great! Thank you.

@edulix
Copy link
Contributor

edulix commented Nov 14, 2023

Reopening, it doesn't work without lists. I attach an example:
https://gist.github.com/ElectricPaperInformationssystemeGmbH/111999522cc1921e73c4572a32d2c385

@edulix
Copy link
Contributor

edulix commented Nov 14, 2023

Please @ElectricPaperInformationssystemeGmbH test it in branch feat/meta-211/10.0.x of the voting-booth and tell me if it works as expected

@ElectricPaperInformationssystemeGmbH
Copy link

ElectricPaperInformationssystemeGmbH commented Nov 14, 2023

@edulix Unfortunately, the original problem occurs again
image

@ElectricPaperInformationssystemeGmbH

@edulix link is same as you've added before

@edulix
Copy link
Contributor

edulix commented Nov 15, 2023

@ElectricPaperInformationssystemeGmbH the example I mentioned in the comment has only 2 checkboxes per candidate. I've modified it to contain 10. It looks like this in mobile:
image

I think it's working properly.

@ElectricPaperInformationssystemeGmbH

looks good, thank you

edulix added a commit to sequentech/voting-booth that referenced this issue Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epi-1 EPI-1 project
Projects
None yet
Development

No branches or pull requests

2 participants